Fix timeout report generation race #816
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #816 +/- ##
==========================================
- Coverage 99.26% 99.05% -0.21%
==========================================
Files 25 25
Lines 950 954 +4
==========================================
+ Hits 943 945 +2
- Misses 6 7 +1
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
When fx is run with a very short timeout, it's possible for the timeout error message to be in a bad format "OnStart hook added by failed" where the name of the OnStart hook's caller hasn't been recorded before the context times out. This fixes the error message generation to not rely on the OnStart hook's caller always being known to fix this race. Fixes uber-go#815
16da6a1 to
1a810d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When fx is run with a very short timeout, it's possible for the
timeout error message to be in a bad format "OnStart hook added by failed"
where the name of the OnStart hook's caller hasn't been recorded
before the context times out.
This fixes the error message generation to not rely on the OnStart hook's
caller always being known to fix this race.
Fixes #815