Thanks to visit codestin.com
Credit goes to github.com

Skip to content

all: modernize #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abhinav merged 1 commit into from
Sep 14, 2025
Merged

all: modernize #1276

abhinav merged 1 commit into from
Sep 14, 2025

Conversation

@abhinav
Copy link
Collaborator

@abhinav abhinav commented Sep 11, 2025

Run the modernize linter across the codebase.
Change generated by running:

go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...

Ref: https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize

@abhinav
Copy link
Collaborator Author

abhinav commented Sep 11, 2025 •
edited
Loading

This change is part of the following stack:

Change managed by git-spice.

This was referenced Sep 11, 2025
Merged
Merged
@codecov
Copy link

codecov bot commented Sep 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.64%. Comparing base (21e34ec) to head (6a24101).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1276   +/-   ##
=======================================
  Coverage   98.64%   98.64%           
=======================================
  Files          35       35           
  Lines        3458     3458           
=======================================
  Hits         3411     3411           
  Misses         40       40           
  Partials        7        7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rabbbit
Copy link

rabbbit commented Sep 12, 2025 •
edited
Loading

(am I meant to merge anything or do you still have powers abg? I'm also not sure about the stack thing- do you want to land it all together?)

@abhinav
Copy link
Collaborator Author

abhinav commented Sep 13, 2025

Thanks!
The stack has to be landed bottom-up, so after the bottom-most is approved, I will rebase the rest and then we can merge the new bottom-most PR, and so on.
I think I still have privileges to press merge once the PR is approved.

Base automatically changed from golangci-lint-v2 to master September 14, 2025 16:21
@abhinav
all: modernize
6a24101 
Run the modernize linter across the codebase.
Change generated by running:

```
go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize@latest -fix -test ./...
```

Ref: https://pkg.go.dev/golang.org/x/tools/gopls/internal/analysis/modernize
@abhinav abhinav merged commit 6fab1b2 into master Sep 14, 2025
17 of 18 checks passed
@abhinav abhinav deleted the modernize branch September 14, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rabbbit rabbbit rabbbit approved these changes

@r-hang r-hang r-hang approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abhinav @rabbbit @r-hang