Check scope existence lock free first #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
SokolAndrey
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
i thought computeIfAbsent does exactly that. Strange that it makes a difference
brawndou
reviewed
Jan 9, 2023
core/build.gradle
Outdated
79a9e99 to
0a0f137
Compare
sairamch04
pushed a commit
to sairamch04/tally
that referenced
this pull request
Feb 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have found that for java applications running on big machines (>8 cores) we start to see sudden spikes in latency. For instance a 32 core service gets a 100 ms spike which affect our p99.9.
By calling .get() before computeIfAbsent() we are able to reduce the impact of this (we can't completely remove it because we could still be allocating new keys).
We added a benchmark to demonstrate this. The 32 thread results are as follows:
Before the fix
After the fix
