Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support for extra Futures classes#909

Merged
msridhar merged 1 commit intouber:masterfrom
msridhar:support-alternate-futures-classes
Feb 15, 2024
Merged

Support for extra Futures classes#909
msridhar merged 1 commit intouber:masterfrom
msridhar:support-alternate-futures-classes

Conversation

@msridhar
Copy link
Collaborator

@msridhar msridhar commented Feb 14, 2024

This allows for a list of classes to be passed in via a command-line argument -XepOpt:NullAway:ExtraFuturesClasses. Such classes will be treated equivalently to built-in Guava Futures classes via the FluentFutureHandler. This is a follow-up to #771.

@msridhar msridhar requested a review from yuxincs February 14, 2024 18:56
@codecov
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (3fc9b8a) 86.98% compared to head (e8127e5) 87.07%.
Report is 4 commits behind head on master.

Files Patch % Lines
...c/main/java/com/uber/nullaway/NullabilityUtil.java 66.66% 1 Missing and 2 partials ⚠️
...away/src/main/java/com/uber/nullaway/NullAway.java 93.75% 0 Missing and 2 partials ⚠️
...ava/com/uber/nullaway/generics/GenericsChecks.java 88.88% 0 Missing and 2 partials ⚠️
...src/main/java/com/uber/nullaway/LibraryModels.java 66.66% 1 Missing ⚠️
...llaway/dataflow/AccessPathNullnessPropagation.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #909      +/-   ##
============================================
+ Coverage     86.98%   87.07%   +0.09%     
- Complexity     1959     1989      +30     
============================================
  Files            77       77              
  Lines          6330     6423      +93     
  Branches       1223     1244      +21     
============================================
+ Hits           5506     5593      +87     
- Misses          420      422       +2     
- Partials        404      408       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

yuxincs
yuxincs approved these changes Feb 14, 2024
View reviewed changes
Copy link
Collaborator

@yuxincs yuxincs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for allowing more customizations of handling Future classes.

@msridhar msridhar merged commit 91d6809 into uber:master Feb 15, 2024
@msridhar msridhar deleted the support-alternate-futures-classes branch February 15, 2024 01:33
@tbroyer
Copy link
Contributor

tbroyer commented Feb 16, 2024

Could https://github.com/uber/NullAway/wiki/Configuration be updated? as 0.10.23 was released with this change
(I generally copy the description to my Gradle plugin, to make sure I don't describe things wrong)
TIA

@msridhar
Copy link
Collaborator Author

msridhar commented Feb 16, 2024

Thanks for the reminder! I've added docs here:

https://github.com/uber/NullAway/wiki/Configuration#extra-futures-classes

@tbroyer
Copy link
Contributor

tbroyer commented Feb 16, 2024

Thanks, just published version 2.0.0 of the plugin that adds support for this in the DSL (major version bump due to removing support for Gradle 5.2 → 6.7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuxincs yuxincs yuxincs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@msridhar @tbroyer @yuxincs

Comments