Properly handle method references to null-unmarked methods #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1205 +/- ##
============================================
+ Coverage 88.21% 88.23% +0.02%
- Complexity 2317 2325 +8
============================================
Files 88 88
Lines 7578 7583 +5
Branches 1513 1516 +3
============================================
+ Hits 6685 6691 +6
Misses 448 448
+ Partials 445 444 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yuxincs
approved these changes
Apr 30, 2025
dhruv-agr
pushed a commit
to dhruv-agr/NullAway
that referenced
this pull request
May 9, 2025
Fixes uber#1195 We adjust our method overriding checks for a method reference to a `@NullUnmarked` method. Any overriding should be allowed, except in the presence of a restrictive annotation (`@Nullable` on the return or `@NonNull` on a parameter). Also add tests for `@NonNull` on the varargs parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1195
We adjust our method overriding checks for a method reference to a
@NullUnmarkedmethod. Any overriding should be allowed, except in the presence of a restrictive annotation (@Nullableon the return or@NonNullon a parameter). Also add tests for@NonNullon the varargs parameter.