Thanks to visit codestin.com
Credit goes to github.com

Skip to content

JSpecify: Fix crash when overriding with raw types #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msridhar merged 3 commits into from
Aug 28, 2025
Merged

JSpecify: Fix crash when overriding with raw types #1265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c360253
test case
msridhar Aug 28, 2025
41ef2c4
fix
msridhar Aug 28, 2025
ebef64f
CodeRabbit feedback
msridhar Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nullaway/src/main/java/com/uber/nullaway/generics/TypeSubstitutionUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ private static class RestoreNullnessAnnotationsVisitor extends Types.MapVisitor<

@Override
public Type visitMethodType(Type.MethodType t, Type other) {
Type.MethodType otherMethodType = (Type.MethodType) other;
// other can be a ForAll whose qtype is a MethodType; asMethodType() safely unwraps it.
Type.MethodType otherMethodType = other.asMethodType();
List<Type> argtypes = t.argtypes;
Type restype = t.restype;
List<Type> thrown = t.thrown;
Expand Down
25 changes: 25 additions & 0 deletions nullaway/src/test/java/com/uber/nullaway/jspecify/GenericInheritanceTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,31 @@ public void methodInvocationTypeVarReceiver() {
.doTest();
}

/** For issue 1264. Checks that we don't crash when overriding with raw types. */
@Test
public void overrideWithRawTypes() {
makeHelper()
.addSourceLines(
"Test.java",
"import org.jspecify.annotations.NullMarked;",
"@NullMarked",
"public class Test {",
" static class A<T> {}",
" static class B<T> {",
" public <X> X accept(A<X> a) {",
" throw new RuntimeException();",
" }",
" }",
" static class Raw extends B {",
" @Override",
" public Object accept(A a) {",
" throw new RuntimeException();",
" }",
" }",
"}")
.doTest();
}

private CompilationTestHelper makeHelper() {
return makeTestHelperWithArgs(
Arrays.asList(
Expand Down
Loading