Replace the SharedFlow with a StateFlow in the Interactor class #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psteiger
reviewed
Aug 5, 2025
| return rxCompletable(RibDispatchers.Unconfined + context) { | ||
| takeWhile { it < range.endInclusive }.collect() | ||
| takeWhile { | ||
| it == null || it < range.endInclusive |
Contributor
There was a problem hiding this comment.
Should we use something like CREATED for the initial state?
Contributor
Author
There was a problem hiding this comment.
It would be best to use null for now to minimize the change and if we do decide to remove the MutableSharedFlow, we can introduce the CREATED state.
| public open val lifecycleFlow: SharedFlow<InteractorEvent> | ||
| get() = _lifecycleFlow | ||
|
|
||
| private var useStateFlow = true |
Contributor
There was a problem hiding this comment.
Who sets this? I don't see it being set
Contributor
Author
There was a problem hiding this comment.
missed this. let me update it
d169715 to
ccde6bf
Compare
psteiger
approved these changes
Aug 13, 2025
| private val useStateFlow = RibEvents.useStateFlowInteractorEvent | ||
|
|
||
| private val _lifecycleFlow: MutableSharedFlow<InteractorEvent?> = | ||
| if (useStateFlow) |
Contributor
There was a problem hiding this comment.
Suggest to use brackets if multi-line if-else
| public open val lifecycleFlow: SharedFlow<InteractorEvent> | ||
| get() = _lifecycleFlow | ||
|
|
||
| private val useStateFlow = RibEvents.useStateFlowInteractorEvent |
Contributor
There was a problem hiding this comment.
Hm, we can probably save an allocation here. Let's just use get() = RibEvents.useStateFlowInteractorEvent
ccde6bf to
2ffd489
Compare
… the ANR stacktraces and reduce ANRs
2ffd489 to
586d0fe
Compare
psteiger
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using SharedFlow can lead to ANRs when the consumer is slow and the producer emits on the main thread.
Replacing it reduces the likelihood of ANRs and improves traceability when they do occur.
This will be a seamless change outside the Interactor.