Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: fix upload step unit_test job #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2025
Merged

fix: fix upload step unit_test job #439

merged 1 commit into from
Aug 25, 2025

Conversation

@sambhav-jain-16
Copy link
Collaborator

@sambhav-jain-16 sambhav-jain-16 commented Aug 22, 2025 •
edited
Loading

The upload step of the unit test CI job was failing due to the fact that
the go test commad was not even emitting json. This change aims to fix
that also.

@sambhav-jain-16 sambhav-jain-16 force-pushed the fix-test-results branch 3 times, most recently from d5cfbad to ce3a37d Compare August 22, 2025 12:59
@sambhav-jain-16 sambhav-jain-16 changed the title fix test results upload feat: add test summary to GH Actions CI for unit_test job Aug 22, 2025
@sambhav-jain-16 sambhav-jain-16 force-pushed the fix-test-results branch 2 times, most recently from 432726f to c8acd48 Compare August 22, 2025 13:39
@sambhav-jain-16 sambhav-jain-16 changed the title feat: add test summary to GH Actions CI for unit_test job fix: fix upload step unit_test job Aug 22, 2025
@sambhav-jain-16
fix: fix upload step unit_test job
6c48053 
The upload step of the unit test CI job was failing due to the fact that
the go test commad was not even emitting json. This change aims to fix
that also.
@sambhav-jain-16 sambhav-jain-16 marked this pull request as ready for review August 22, 2025 13:42
@egorikas
Copy link
Collaborator

egorikas commented Aug 22, 2025

Could you help me understand, when upload step should be executed? On which actions? I've checked the configuration and history of executions, but I am not really fully following.

@sambhav-jain-16
Copy link
Collaborator Author

sambhav-jain-16 commented Aug 22, 2025

Could you help me understand, when upload step should be executed? On which actions? I've checked the configuration and history of executions, but I am not really fully following.

The current unit test job has an upload step which uploads the test result as a json. Currently the step is doing nothing since the go test command was not outputting any json. So that step was just silently exiting with the following warning.

Screenshot 2025-08-22 at 18 45 50

egorikas
egorikas approved these changes Aug 22, 2025
View reviewed changes
Copy link
Collaborator

@egorikas egorikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got an answer. The change is for Upload Go test result action
https://github.com/uber/kraken/actions/runs/17045193705/job/48319039157

image

@sambhav-jain-16 sambhav-jain-16 merged commit d27b4b1 into uber:master Aug 25, 2025
9 checks passed
@sambhav-jain-16 sambhav-jain-16 deleted the fix-test-results branch August 25, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@egorikas egorikas egorikas approved these changes

@gkeesh7 gkeesh7 Awaiting requested review from gkeesh7

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sambhav-jain-16 @egorikas