Avoid building duplicate wheels #474
Merged
+15
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting the following error when checking the wheels before uploading to PyPI: https://github.com/uber/h3-py/actions/runs/20215109025/job/58048009774:
I was initially confused, because we check with Twine earlier in the action, so I didn't understand why that was passing, but this later check with Twine was failing. It turns out, that macos 14 and 15 build exactly the same wheels, so the checks pass independently, but we then combine all the wheels into a single tarball, which is corrupted because we compress two copies of the mac wheels with exactly the same filename. (Or, at least, that's my guess of what's going on.)
This PR drops macos 14 from generating wheels, which should fix the issue.
update: Added a twine check after forming the tarball, which should catch this issue earlier than during release. Checked that we get the expected failure below.