Expose cython API for external use #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 425 425
=========================================
Hits 425 425 Continue to review full report at Codecov.
|
Contributor
Author
|
Ah the test script in cibuildwheel needs to be updated to either ignore the Cython test or compile the cython file used in that test. |
Contributor
Author
|
I updated to ignore the test when the cython example wasn't compiled |
ajfriend
approved these changes
May 13, 2022
Collaborator
|
Sweeeeeeet! |
Collaborator
|
Really simple notebook example for future reference: https://gist.github.com/ajfriend/167afffde74bc08b0e809e10b92ecde3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
CMakeLists.txtto include.pyxand.pxdfiles in distribution after skbuild is done processingh3api.hin final bundle. This can usually be found automatically when compiling, but if we have issues with this in the future, we can emulate Numpy and itsnp.get_includefunction.Closes #152