Replace _out_unordered and _out_ordered with _out_collection #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #339 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 324 319 -5
=========================================
- Hits 324 319 -5 ☔ View full report in Codecov by Sentry. |
isaacbrodsky
approved these changes
Jan 12, 2024
Collaborator
isaacbrodsky
left a comment
There was a problem hiding this comment.
You might want to mention in the respective doc strings that the ordering is not guaranteed from these functions.
Collaborator
Author
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the APIs so that functions that would previously return sets of cells now return lists of cells.