Conversation
benshope
left a comment
There was a problem hiding this comment.
Looks good to me! At first glance it seems like there are three things that a user might want to be able to edit on this visualization - the radius, the color scale, and the x/y offset of the hexes. It seems like you have given the user access to those properties - although I'm not sure about x/y offset?
The reason I ask is because I could see users wanting to shift the hex placement to peer around the minor distortions this makes to their data.
It would be awesome to have a color example. Overall it looks very cool.
src/plot/series/hexbin-series.js
Outdated
| {hexes.map((d, i) => { | ||
| const attrs = { | ||
| style: { | ||
| ...style |
There was a problem hiding this comment.
could probably skip this destructure
|
Just chatted with @nrabinowitz because he knows his hexagons and he's going to take a look |
|
Added docs and binning with sizing, built another example (that's pretty fun to play with tbh) and addressed @benshope 's comments. Still interested to hear comments obv |
benshope
left a comment
There was a problem hiding this comment.
Those examples look awesome! At second glance this still looks like reasonably simple, easy-to-understand API for the component. Stamping.
* Hexbin Series * fix tests * add docs and size hexbinning * add offsets
* Hexbin Series * fix tests * add docs and size hexbinning * add offsets
This PR introduces a hexbin series. It is a little different than previous heatmap series that we provide in that the aggregation (though we could staple similar methods into the main heatmap series) is executed on the series level rather than being provided by the user. I think this is a valuable series to add as it might be difficult for users to do otherwise, it also sits well with the uh hexagonal branding that's in the air these days.
In the current state I have not yet written docs as I am not 100% sure about the API. I'd love to hear any feedback