Allow to link back to another label for continuation of push #1193
Conversation
|
PostgresServerNexus::update_superuser_password also has retval check (which is added after this PR) |
325e871 to
ff70d19
Compare
97576c6 to
7b51464
Compare
fdr
left a comment
There was a problem hiding this comment.
can next_label be required? maybe the old retval form has no virtues and should be eliminated.
If the prog runs and returns some values, it could be helpful. Of course, we might be able to find an alternative solution. ubicloud/prog/download_boot_image.rb Line 52 in 7b51464 |
Can't the continuation also look at |
ff70d19 to
64cb193
Compare
64cb193 to
a6c6e5f
Compare
a6c6e5f to
a170921
Compare
7b51464 to
4c99a22
Compare
4c99a22 to
78d9fb0
Compare
We use a custom rspec matcher to verify hop events. In certain tests, it's necessary to examine the details of the hop exception. Therefore, we've made a change to pass the hop exception to the rspec helper, enabling us to check the exception details within the rspec matcher.
Pushing is becoming popular these days. If you're budding a single prog and don't require concurrency, push is a better option than bud. At present, its usage pattern is complex. You need to check the retval of push in the same label you pushed, then move to the next label. However, we can simplify this by allowing a link back to another label for the continuation of push. This way, the pushed program returns the next label instead of the previous one.
78d9fb0 to
63fa164
Compare
Pass hop exception to the custom rspec matcher
We use a custom rspec matcher to verify hop events. In certain tests,
it's necessary to examine the details of the hop exception. Therefore,
we've made a change to pass the hop exception to the rspec helper,
enabling us to check the exception details within the rspec matcher.
Allow to link back to another label for continuation of push
Pushing is becoming popular these days. If you're budding a single prog
and don't require concurrency, push is a better option than bud.
At present, its usage pattern is complex. You need to check the retval
of push in the same label you pushed, then move to the next label.
However, we can simplify this by allowing a link back to another label
for the continuation of push. This way, the pushed program returns the
next label instead of the previous one.
Fixes #1187