Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jeremyevans
Copy link
Contributor

@jeremyevans jeremyevans commented Oct 21, 2025

This removes the methods to convert postgres resources and kubernetes clusters to have internal firewalls and customer firewalls and subnets.

It also simplifies the code by assuming the internal firewalls always exist.


Important

Remove methods for converting resources to have internal/customer firewalls, assuming internal firewalls always exist, and update tests accordingly.

  • Behavior:
    • Removes methods for converting Postgres resources and Kubernetes clusters to have internal and customer firewalls in kubernetes_cluster.rb and postgres_resource.rb.
    • Assumes internal firewalls always exist, simplifying related logic.
  • Code Simplification:
    • Removes conditional checks for the existence of internal firewalls in kubernetes_cluster.rb, postgres_resource.rb, and nexus classes.
    • Updates destroy methods in nexus classes to directly destroy internal firewalls without conditional checks.
  • Tests:
    • Updates test cases in postgres_resource_spec.rb, kubernetes_cluster_nexus_spec.rb, and postgres_server_nexus_spec.rb to align with the new firewall assumptions.
    • Removes tests related to the conditional existence of internal firewalls.

This description was created by Ellipsis for 8239fc9. You can customize this summary. It will automatically update as commits are pushed.

@jeremyevans jeremyevans force-pushed the jeremy-pg-k8s-net-change-phase-4 branch from 6bb2095 to e150f3e Compare October 22, 2025 00:01
@jeremyevans jeremyevans force-pushed the jeremy-pg-k8s-net-change-phase-5 branch from 8239fc9 to b1af0fa Compare October 22, 2025 00:01
@jeremyevans jeremyevans force-pushed the jeremy-pg-k8s-net-change-phase-4 branch from e150f3e to 9c9ff9e Compare October 22, 2025 17:36
@jeremyevans jeremyevans force-pushed the jeremy-pg-k8s-net-change-phase-5 branch from b1af0fa to 24c979a Compare October 22, 2025 17:37
@jeremyevans jeremyevans force-pushed the jeremy-pg-k8s-net-change-phase-4 branch from 9c9ff9e to 9c28af5 Compare October 23, 2025 22:03
@jeremyevans jeremyevans force-pushed the jeremy-pg-k8s-net-change-phase-5 branch from 24c979a to eb22d12 Compare October 23, 2025 22:03
@jeremyevans jeremyevans force-pushed the jeremy-pg-k8s-net-change-phase-4 branch from 9c28af5 to b9387d0 Compare October 24, 2025 23:41
@jeremyevans jeremyevans force-pushed the jeremy-pg-k8s-net-change-phase-5 branch from eb22d12 to 50081a7 Compare October 24, 2025 23:41
@jeremyevans jeremyevans force-pushed the jeremy-pg-k8s-net-change-phase-4 branch from b9387d0 to 558f64e Compare October 27, 2025 18:17
Base automatically changed from jeremy-pg-k8s-net-change-phase-4 to main October 27, 2025 18:28
@jeremyevans jeremyevans force-pushed the jeremy-pg-k8s-net-change-phase-5 branch from 50081a7 to 55d1760 Compare October 27, 2025 18:40
@jeremyevans jeremyevans merged commit 3aeb544 into main Oct 27, 2025
11 checks passed
@jeremyevans jeremyevans deleted the jeremy-pg-k8s-net-change-phase-5 branch October 27, 2025 18:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants