Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@8845musign
Copy link
Contributor

@8845musign 8845musign commented Nov 1, 2024

Changes

blocked by #139

  • add prefixIcon prop to Button components
    • It is clearer to use “prefix” rather than simply “icon”.
    • unify naming with suffixIcon
  • prefixIcon is icon alias
    • I want to delete the icon prop, but it will take a lot of time, so I'll add an alias for now.

Screenshots

Button:
スクリーンショット 2024-11-01 21 55 48

LinkButton:
スクリーンショット 2024-11-01 21 56 20

Check

No change to the rendering result

  • [-] Browser verification (minimum) Android Chrome/iOS Safari(375px-)
  • [-] CSS not affected by inheritance
  • [-] Layout does not break even if there is an overflow
  • [-] Layout does not break when wraps
  • [-] Added new Component
    • Added data-* prop and id prop
  • [-] Updated Ubie Vitals or Added an update issue(if needed)

@8845musign 8845musign marked this pull request as ready for review November 1, 2024 13:03
@8845musign 8845musign requested a review from takanorip as a code owner November 1, 2024 13:03
@takanorip takanorip merged commit bd3ce39 into ubie-oss:main Nov 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants