Feat/encode url #41
Merged
Feat/encode url #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
d8fa0e1 to
45e1654
Compare
Avantol13
reviewed
Aug 9, 2019
| ) | ||
| signature = generate_signature(signing_key.key, string_to_sign) | ||
|
|
||
| # escape special characters _after_ generating the signature, to match the |
Contributor
There was a problem hiding this comment.
this doesn't really require that it happens after, right? like this line could be right after 136. it's just that the signature is calculated with literal spaces
3e19261 to
f17c0e9
Compare
Avantol13
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PXP-3646: encode spaces in file names in presigned URLs to follow RFC 1738
Improvements