(PXP-8993): Support updating user and expiring user policy #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
| backoff = "~=1.6" | ||
| httpx = ">=0.20.0,<1.0.0" | ||
| contextvars = { version = "^2.4", python = "<3.7" } | ||
| six = "^1.16.0" |
Avantol13
requested changes
Nov 29, 2021
| Args: | ||
| username (str): MUST be user's username, and not serial user ID | ||
| policy_id (str): Arborist policy id | ||
| expires_at (datetime.datetime): when the policy should expire (in UTC) |
Contributor
There was a problem hiding this comment.
we use/pass around POSIX timestamps in most of the Gen3 stack, since it's arborist that needs UTC, can we handle all that in this function? e.g. can we pass in an integer POSIX timestamp here and do the https://github.com/uc-cdis/fence/pull/986/files#diff-5824dff91d0ccd46626b8d7fbb03bcc2eb6882c9c038139c48ccfd8c39082d70R1670 stuff here? so fence still just handles/passes ints around?
Avantol13
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: PXP-8993
New Features
Dependency updates
six = "^1.16.0"topyproject.toml