Conversation
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
gen3/auth.py
Outdated
| "No idp matched with the endpoint or idp value provided.\n" | ||
| + "Please make sure your endpoint or idp value matches exactly with the output below.\n" | ||
| + "i.e. check trailing '/' character for the endpoint url\n" | ||
| + "Avalable Idps:" |
Contributor
There was a problem hiding this comment.
Suggested change
| + "Avalable Idps:" | |
| + "Available Idps:" |
gen3/auth.py
Outdated
| "No idp matched with the endpoint or idp value provided.\n" | ||
| + "Please make sure your endpoint or idp value matches exactly with the output below.\n" | ||
| + "i.e. check trailing '/' character for the endpoint url\n" | ||
| + "Avalable Idps:" |
Contributor
There was a problem hiding this comment.
How about using triple quotes for the ValueError string so that \n and + aren't required?
Contributor
Author
There was a problem hiding this comment.
I experimented with using triple quotes string. I needed to format in the idp_list variable and somehow this makes the error message look funky with all the extra indents. See below. Tried to solve this using textwrap.dedent() and inspect.cleandoc() but neither work with a string that's been formatted. Think keeping it as is probably the way to go for now.
ValueError: No idp matched with the endpoint or idp value provided. Please make sure your endpoint or idp value matches exactly with the output below. i.e. check trailing '/' character for the endpoint url Available Idps: idp name: test-google Endpoint url: https://test-commons.org Query /wts/external_oidc/ for more information.
johnfrancismccann
approved these changes
Jul 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BMH-111
Improvements
Logging and error improvement.