Fix(PXP-3968): Fix explorer download button not disabled #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bug: Sometimes, the download button in explorer (button type='data') is not disabled when viewing metadata or files the user does not have access to. - Cause: Data from guppy is validated using the 'accessibleValidationField' in the guppy config, but the 'accessibleValidationField' was not always included by default in the data requested from guppy. If the 'accessibleValidationField' was not included, the data validation check that enables/ disables the 'data' button would fail and default to 'enabled.' - Fix: Always fetch 'accessibleValidationField' from guppy. This is done by always fetching the fields in 'accessibleFieldCheckList', which includes 'accessibleValidationField'.
em-ingram
commented
Oct 30, 2019
| onProcessFilterAggsData: PropTypes.func, | ||
| onUpdateAccessLevel: PropTypes.func, | ||
| adminAppliedPreFilters: PropTypes.object, | ||
| accessibleFieldCheckList: PropTypes.arrayOf(PropTypes.string), |
Contributor
Author
There was a problem hiding this comment.
GuppyWrapper now passes accessibleFieldChecklist down as props to its children (including ConnectedFilter.)
mfshao
reviewed
Oct 30, 2019
Contributor
|
cool! is this branch deployed to your dev env now? |
Contributor
Author
Not yet -- it was just on my local! I'll deploy it to my portal, I'll message when it's up. |
Contributor
Author
|
This version of guppy is running on my dev commons at https://mpingram.planx-pla.net/explorer. (Use dev_login: [email protected] to replicate the conditions the bug was found in) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ctds-planx.atlassian.net/browse/PXP-3968
Bug Fixes
Fix bug in Windmill explorer in which download buttons would sometimes appear to be enabled, even if users didn't have access to all data.