Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PXP-4794 PXP-4534 Fix/tiered access #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfshao merged 14 commits into from
Feb 26, 2020
Merged

PXP-4794 PXP-4534 Fix/tiered access #75

mfshao merged 14 commits into from
Feb 26, 2020

Conversation

@mfshao
Copy link
Contributor

@mfshao mfshao commented Feb 17, 2020 •
edited
Loading

This PR fulfills https://ctds-planx.atlassian.net/browse/PXP-4794 and https://ctds-planx.atlassian.net/browse/PXP-4534

This is the accompanying PR for uc-cdis/gen3-ui-component#63

Both issues were due to that the old tiered access control logic of guppy doesn't discriminate if an aggregation result has portions which are acutally accessible by user.

Improvements

  • Tiered access logic will checks for portions which are accessible by user, and encypt results with that information in consideration
  • Checked filters won't get disabled unless they get unchecked first
  • Charts won't be hidden unless they contain any field from unaccessible resources which has a total count less than the tier access limit
  • ENV_VAR log_level can be set from manifest

Dependency updates

  • gen3-ui-component: 0.3.16

@mfshao mfshao mentioned this pull request Feb 17, 2020
Merged
@em-ingram
Copy link
Contributor

em-ingram commented Feb 21, 2020

Noticed some behavior in the explorer I didn't understand with this change:
(This logged in as planxdemo)

  1. Select All Data
  2. Select project dev-test
  3. Select Gender: Unknown
  4. Unselect project dev-test
    Filters are now in a weird state -- project dev-test is stuck with only the Gender: Unknown subjects. I think I expect that the Gender: Unknown filter is unset when I unselect dev-test

em-ingram
em-ingram suggested changes Feb 21, 2020
View reviewed changes
Copy link
Contributor

@em-ingram em-ingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Requesting changes for confusing interaction specified in my comment

em-ingram
em-ingram previously approved these changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@em-ingram em-ingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mfshao mfshao merged commit 67da927 into master Feb 26, 2020
@mfshao mfshao deleted the fix/tiered-access branch February 26, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@em-ingram em-ingram em-ingram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mfshao @em-ingram