Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(filter): add search to filter and also boost speed #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
qingyashu merged 10 commits into from
Feb 20, 2020
Merged

feat(filter): add search to filter and also boost speed #76

qingyashu merged 10 commits into from
Feb 20, 2020

Conversation

@qingyashu
Copy link
Contributor

@qingyashu qingyashu commented Feb 18, 2020 •
edited
Loading

New Features

  • add search input box to filter

Improvements

  • add a hidden prop to ConnectedFilter to reduce unnecessary calculation thus boost rendering speed
  • rewrite update filter tabs function and decrease time complexity from O(n^3) to O(n^2)

@lgtm-com
Copy link

lgtm-com bot commented Feb 18, 2020

This pull request introduces 1 alert when merging c454475 into 2b2c520 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

mfshao
mfshao previously approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

for the hidden prop, is there a use case that we want to hide the entire filters?

@qingyashu
Copy link
Contributor Author

qingyashu commented Feb 19, 2020

lgtm

for the hidden prop, is there a use case that we want to hide the entire filters?

oh yes, the HeatMap will definitely need this. Since DAT is filtering by subject_id, this hidden prop will hugely reduce calculation time.

@mfshao
Copy link
Contributor

mfshao commented Feb 19, 2020

lgtm
for the hidden prop, is there a use case that we want to hide the entire filters?

oh yes, the HeatMap will definitely need this. Since DAT is filtering by subject_id, this hidden prop will hugely reduce calculation time.

oh right! the DAT!

thanks for explaining this 💯

@qingyashu
Copy link
Contributor Author

qingyashu commented Feb 19, 2020

Sorry I just patched one more commit to handle the range slider. I am starting to deploying it to qa-ibd or other QA now.

mfshao
mfshao reviewed Feb 19, 2020
View reviewed changes
@qingyashu qingyashu requested a review from mfshao February 20, 2020 17:13
mfshao
mfshao previously approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ZakirG
ZakirG approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@ZakirG ZakirG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job on the optimization ~ thank u!!

@qingyashu qingyashu merged commit 7ce78a0 into master Feb 20, 2020
@mfshao mfshao deleted the fix/filter branch July 14, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfshao mfshao mfshao left review comments

@em-ingram em-ingram Awaiting requested review from em-ingram

+1 more reviewer

@ZakirG ZakirG ZakirG approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qingyashu @mfshao @ZakirG