Thanks to visit codestin.com
Credit goes to github.com

Skip to content

PXP-5773 Fix/no jwt 401 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfshao merged 2 commits into from
Mar 31, 2020
Merged

PXP-5773 Fix/no jwt 401 #80

mfshao merged 2 commits into from
Mar 31, 2020

Conversation

@mfshao
Copy link
Contributor

@mfshao mfshao commented Mar 31, 2020 •
edited
Loading

This PR fulfills https://ctds-planx.atlassian.net/browse/PXP-5773

Since Arborist now has policies for unauthenticated users, Guppy should not simply returns 401 if user doesn't have JWT.

This is achieved by changing the way that Guppy is interacting with the /auth/resources endpoint from POST to GET

Deployed to https://mingfei.planx-pla.net/

Improvements

  • Guppy will not always return 401 for user who doesn't have a JWT

@mfshao mfshao requested a review from paulineribeyre March 31, 2020 21:28
@mfshao mfshao merged commit fc10343 into master Mar 31, 2020
@mfshao mfshao deleted the fix/no-jwt-401 branch March 31, 2020 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulineribeyre paulineribeyre paulineribeyre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mfshao @paulineribeyre