Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mfshao
Copy link
Contributor

@mfshao mfshao commented Jul 30, 2020

This PR fulfills https://ctds-planx.atlassian.net/browse/PXP-6510

Modify Guppy to NOT return a list of out-of-scope resources in its response if users are trying to query something that they don't have access to, since those information could be confidential.

Try at: https://mingfei.planx-pla.net/query

Improvements

  • Guppy will NOT return the list of out-of-scope resources in its response to the public
  • The list of out-of-scope resources will be printed into logs

Copy link
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool, thanks

@mfshao mfshao merged commit 45f1271 into master Jul 30, 2020
@mfshao mfshao deleted the fix/log branch July 30, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants