Feat/and or filter toggle #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 55df07f into eae5c93 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 4fd0003 into eae5c93 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 51b55ab into eae5c93 - view on LGTM.com new alerts:
|
em-ingram
reviewed
Dec 1, 2020
Contributor
em-ingram
left a comment
There was a problem hiding this comment.
LGTM, 2 minor comments
| import flat from 'flat'; | ||
| import { queryGuppyForRawDataAndTotalCounts } from '../Utils/queries'; | ||
| // import esInstance from '../../server/es/index'; | ||
| // import config from '../../server/config'; |
em-ingram
approved these changes
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a config gear symbol on checkbox filters that let you specify the filter combine mode: AND or OR.
Jira Ticket: https://ctds-planx.atlassian.net/browse/PXP-6542
Partner PR in gen3-ui-component: uc-cdis/gen3-ui-component#77
New Features