Thanks to visit codestin.com
Credit goes to github.com

Skip to content

(PXP-6359) Add Search Filter #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
em-ingram merged 11 commits into from
Oct 14, 2020
Merged

(PXP-6359) Add Search Filter #99

em-ingram merged 11 commits into from
Oct 14, 2020

Conversation

@em-ingram
Copy link
Contributor

@em-ingram em-ingram commented Sep 21, 2020

Jira Ticket: PXP-6359

New Features

  • Adds a new filter type, searchFilter, to the available filters. Search Filters allow the user to search over fields which have too many options to be displayed normally -- for example, individual subject IDs or file GUIDs.

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

  • To deploy SearchFilters in a tab of the Explorer page, add an entry to data{/file}ExplorerConfig.filters.tabs.searchFields. NOTE: Do not add the same field to both searchFields and fields, this will cause strange behavior in the search field. Example config:
"filters": {
      "tabs": [
        {
          "title": "Subject",
          "searchFields": [
            "subject_id",
            "submitter_id",
            "consent_codes"
          ],
          "fields": [
            "data_type",
            "data_format",
            ...
          ]
        }

@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2020

This pull request introduces 1 alert when merging 3096fe7 into 5b55e6c - view on LGTM.com

new alerts:

  • 1 for Unneeded defensive code

@em-ingram em-ingram mentioned this pull request Sep 21, 2020
Merged
@em-ingram em-ingram changed the title Feat/pxp 6359 search filter (PXP-6359) Add Search Filter Sep 21, 2020
@lgtm-com
Copy link

lgtm-com bot commented Sep 22, 2020

This pull request introduces 1 alert when merging c95525b into 5b55e6c - view on LGTM.com

new alerts:

  • 1 for Unneeded defensive code

@em-ingram em-ingram marked this pull request as ready for review September 29, 2020 19:23
@em-ingram em-ingram requested review from ZakirG and mfshao and removed request for mfshao October 5, 2020 20:04
@lgtm-com
Copy link

lgtm-com bot commented Oct 5, 2020

This pull request introduces 1 alert when merging 5dbab12 into 5b55e6c - view on LGTM.com

new alerts:

  • 1 for Unneeded defensive code

ZakirG
ZakirG reviewed Oct 5, 2020
View reviewed changes
src/components/Utils/queries.js Outdated
return { accessibleFieldObject, unaccessibleFieldObject };
};

export const guppySinglefieldSearch = (path, type, keyword, field, numResults) => {
Copy link
Contributor

@ZakirG ZakirG Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this function get used anywhere?

Copy link
Contributor Author

@em-ingram em-ingram Oct 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, good catch, no it doesn't -- it was originally used here but I refactored it out:

guppy/src/components/ConnectedFilter/utils.js

Lines 63 to 64 in 58913a8

queryGuppyForRawDataAndTotalCounts(
guppyConfig.path,

I'll remove it now!

@lgtm-com
Copy link

lgtm-com bot commented Oct 5, 2020

This pull request introduces 1 alert when merging 8c1f0d4 into 5b55e6c - view on LGTM.com

new alerts:

  • 1 for Unneeded defensive code

mfshao
mfshao approved these changes Oct 5, 2020
View reviewed changes
Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good

@lgtm-com
Copy link

lgtm-com bot commented Oct 6, 2020

This pull request introduces 1 alert when merging d6af8b2 into 5b55e6c - view on LGTM.com

new alerts:

  • 1 for Unneeded defensive code

@lgtm-com
Copy link

lgtm-com bot commented Oct 6, 2020

This pull request introduces 1 alert when merging eb22d3e into 5b55e6c - view on LGTM.com

new alerts:

  • 1 for Unneeded defensive code

@em-ingram em-ingram merged commit 32b2552 into master Oct 14, 2020
@em-ingram em-ingram deleted the feat/pxp-6359-search-filter branch October 14, 2020 20:40
themarcelor pushed a commit that referenced this pull request Nov 5, 2020
@em-ingram
(PXP-6359) Add Search Filter (#99)
ae8c6ee 
* Modify guppy to work with searchField

* Update comments

* Clean up code

* Pin g3uicomponent to branch

* Update package-lock.json

* Random change to retrigger jenkins integration tests

* Revert "Random change to retrigger jenkins integration tests"

This reverts commit 393ad48.

* Remove unused guppySingleFieldSearch function

* Pin gen3uicomponent to 0.6.0

* Bump package version to 0.9.0

* Fix package version
This was referenced Nov 6, 2020
Merged
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Nov 20, 2020
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Feb 24, 2021
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Mar 11, 2021
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request May 10, 2021
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Sep 14, 2021
Merged
@PlanXCyborg PlanXCyborg mentioned this pull request Mar 18, 2022
Merged
This was referenced Dec 18, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfshao mfshao mfshao approved these changes

+1 more reviewer

@ZakirG ZakirG ZakirG left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@em-ingram @mfshao @ZakirG