Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: per-index tiered-access middleware #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZakirG merged 71 commits into from
Feb 17, 2021
Merged

feat: per-index tiered-access middleware #104

ZakirG merged 71 commits into from
Feb 17, 2021

Conversation

@ZakirG
Copy link
Contributor

@ZakirG ZakirG commented Nov 30, 2020 •
edited
Loading

This PR adds support for index-scoped tiered access settings in a manifest's guppy block. This refactor is backwards compatible with the older site-wide tiered-access level.

Jira Ticket: https://ctds-planx.atlassian.net/browse/HP-13

New Features

  • Tiered-access settings can now be optionally specified at the index-level rather than the site-wide level. This change is backwards compatible with existing site-wide tiered-access settings. Specify index-scoped tiered-access settings in the guppy block of a common's manifest. See doc/index_scoped_tiered_access.md for more information.

@ZakirG ZakirG changed the title feat: per-index tier access middleware feat: per-index tiered-access middleware Nov 30, 2020
@lgtm-com
Copy link

lgtm-com bot commented Jan 19, 2021

This pull request introduces 1 alert when merging 944435f into ebf7327 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jan 20, 2021

This pull request introduces 1 alert when merging dfe7856 into ebf7327 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Jan 20, 2021

This pull request introduces 1 alert when merging e0d6b73 into ebf7327 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

mfshao
mfshao reviewed Feb 2, 2021
View reviewed changes
Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The queries looks good, the server looks good. But the data explorer page in your dev env looks a bit weird.
Screen Shot 2021-02-02 at 1 05 44 PM
For regular level explorer tab, the tier_access_limit info seems to be missing. I'm not sure if that is an config issue or bug in the code. I know we haven't updated the frontend component for Guppy, but since tier_access_limit should be a site-wide value, I assume it should not change?

mfshao
mfshao reviewed Feb 3, 2021
View reviewed changes
src/server/download.js Outdated

log.debug('[download] ', JSON.stringify(req.body, null, 4));
const esIndex = esInstance.getESIndexByType(type);
const esIndex = esInstance.getESIndexConfigByType(type);
Copy link
Contributor

@mfshao mfshao Feb 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const esIndex = esInstance.getESIndexConfigByType(type);
const esIndexConfig = esInstance.getESIndexConfigByType(type);

mfshao
mfshao approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome work! this is a hard one, thanks!

code-wise lgtm, awaiting QA now

@ZakirG ZakirG merged commit cc66954 into master Feb 17, 2021
@mfshao mfshao deleted the feat/per-index-tiered-access branch April 20, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfshao mfshao mfshao approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZakirG @mfshao