feat: data explorer query state in url #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfshao
reviewed
Apr 5, 2021
Contributor
mfshao
left a comment
There was a problem hiding this comment.
logically LGTM in general, did you test the and/or toggle feature as well?
also don't forget to update the version number
Dockerfile
Outdated
| && apt-get install -y --no-install-recommends nodejs \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
| && rm -rf /var/lib/apt/lists/* \ | ||
| && npm i -g [email protected] |
Contributor
There was a problem hiding this comment.
let's do this the same way as you have done for Portal, put npm to 7.8.0 and set maxsockets value
mfshao
approved these changes
Apr 9, 2021
package.json
Outdated
| "dependencies": { | ||
| "@elastic/elasticsearch": "^7.0.0-rc.1", | ||
| "@gen3/ui-component": "^0.7.0", | ||
| "@gen3/ui-component": "git+https://github.com/uc-cdis/gen3-ui-component.git#feat/query-state-url", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: https://ctds-planx.atlassian.net/browse/PXP-7517
This PR supports loading and unloading Data Explorer state to and from a URL. The feature currently supports only single-select and range filters. This feature is disabled by default; see uc-cdis/data-portal#807 for more information.
Companion PRs:
uc-cdis/data-portal#807
uc-cdis/gen3-ui-component#98
New Features