Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@grugna
Copy link
Contributor

@grugna grugna commented Jul 16, 2021

When a nested filter is selected in the Exploration page and the aggregation on the same field is requested a null value is assigned to the nested query, which is not a permissible value in ES which returns 400.

Bug Fixes

  • Fixed a bug causing incorrectly putting null into filters that contain nested fields

@mfshao mfshao self-requested a review July 20, 2021 04:59
Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionality wise LGTM, but there are some linting errors

can you do npm run eslint and commit in the changes? that should do the trick

@grugna
Copy link
Contributor Author

grugna commented Jul 20, 2021

@mfshao run, let me know if you need me to do any other change.

Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mfshao mfshao merged commit ee2d941 into uc-cdis:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants