Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: do not include _source field for aggregations #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m0nhawk merged 1 commit into from
Oct 28, 2021
Merged

feat: do not include _source field for aggregations #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/server/es/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,17 +403,21 @@ class ES {
if (typeof size !== 'undefined') {
queryBody.size = size;
}
if (fields) {
const esFields = fromFieldsToSource(fields);
if (esFields.length > 0) queryBody._source = esFields;
if (fields !== undefined) {
Copy link
Contributor

@mfshao mfshao Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't do a single if (typeof fields !== 'undefined') and set queryBody._source = false; in its else clause?

Copy link
Contributor Author

@m0nhawk m0nhawk Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'll break the backward compatibility, in case there is code that doesn't define fields, but still uses _source for something.

if (fields) {
const esFields = fromFieldsToSource(fields);
if (esFields.length > 0) queryBody._source = esFields;
} else {
queryBody._source = false;
}
}
return this.query(esIndex, esType, queryBody);
}

async getCount(esIndex, esType, filter) {
const result = await this.filterData(
{ esInstance: this, esIndex, esType },
{ filter },
{ filter, fields: false },
);
return result.hits.total;
}
Expand Down