Thanks to visit codestin.com
Credit goes to github.com

Skip to content

(PXP-4614): feat/aggregationTermsCount: add total terms count to parent termsFields #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ocshawn merged 9 commits into from
May 2, 2022
Merged

(PXP-4614): feat/aggregationTermsCount: add total terms count to parent termsFields #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
209f606
feat/aggregationTermsCount: add total terms count to parent termsFields
Mar 16, 2022
859ccdd
feat/aggregationTermsCount: add count to schema
Mar 18, 2022
514ab4c
feat/aggregationTermsCount: add count to queries
Mar 18, 2022
7cc0e2d
feat/aggregationTermsCount: revert last two changes
Mar 18, 2022
7e6f865
feat/aggregationTermsCount: place changes back, added count to query …
Mar 21, 2022
209b8ef
Merge branch 'master' into feat/aggregationTermsCount
ocshawn Apr 29, 2022
7091afd
Empty-Commit
Apr 29, 2022
6f7b4a9
Merge branch 'feat/aggregationTermsCount' of github.com:uc-cdis/guppy…
Apr 29, 2022
81d53d3
Empty-Commit
Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/Utils/queries.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ const nestedHistogramQueryStrForEachField = (mainField, numericAggAsText) => (`
}
termsFields {
field
count
terms {
key
count
Expand Down
8 changes: 8 additions & 0 deletions src/server/es/__tests__/aggs.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,6 +931,7 @@ describe('could only aggregate to find missing fields (both existing and non-exi
termsFields: [
{
field: 'gender',
count: 41,
terms: [
{
key: 'male',
Expand All @@ -948,6 +949,7 @@ describe('could only aggregate to find missing fields (both existing and non-exi
},
{
field: 'someNonExistingField',
count: 0,
terms: [
{
key: null,
Expand All @@ -963,6 +965,7 @@ describe('could only aggregate to find missing fields (both existing and non-exi
termsFields: [
{
field: 'gender',
count: 35,
terms: [
{
key: 'male',
Expand All @@ -980,6 +983,7 @@ describe('could only aggregate to find missing fields (both existing and non-exi
},
{
field: 'someNonExistingField',
count: 0,
terms: [
{
key: null,
Expand Down Expand Up @@ -1027,6 +1031,7 @@ describe('could only aggregate to find missing fields (both existing and non-exi
termsFields: [
{
field: 'gender',
count: 41,
terms: [
{
key: 'male',
Expand All @@ -1044,6 +1049,7 @@ describe('could only aggregate to find missing fields (both existing and non-exi
},
{
field: 'someNonExistingField',
count: 0,
terms: [
{
key: null,
Expand All @@ -1069,6 +1075,7 @@ describe('could only aggregate to find missing fields (both existing and non-exi
termsFields: [
{
field: 'gender',
count: 35,
terms: [
{
key: 'male',
Expand All @@ -1086,6 +1093,7 @@ describe('could only aggregate to find missing fields (both existing and non-exi
},
{
field: 'someNonExistingField',
count: 0,
terms: [
{
key: null,
Expand Down
2 changes: 2 additions & 0 deletions src/server/es/aggs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,13 +57,15 @@ const processResultsForNestedAgg = (nestedAggFields, item, resultObj) => {
const tempResult = {};
tempResult.field = element;
tempResult.terms = [];
tempResult.count = 0;
const variableName = `${element}Terms`;
if (item[variableName].buckets && item[variableName].buckets.length > 0) {
item[variableName].buckets.forEach((itemElement) => {
tempResult.terms.push({
key: itemElement.key,
count: itemElement.doc_count,
});
tempResult.count += itemElement.doc_count;
});
} else {
tempResult.terms.push({
Expand Down
1 change: 1 addition & 0 deletions src/server/schema.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,7 @@ export const buildSchemaString = (esConfig, esInstance) => {
const nestedTermsFieldsBucketSchema = `
type BucketsForNestedTermsFields {
field: String
count: Int
terms: [BucketsForString]
}
`;
Expand Down