Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update apollo server and graphql #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ocshawn merged 8 commits into from
Aug 8, 2023
Merged

update apollo server and graphql #226

ocshawn merged 8 commits into from
Aug 8, 2023

Conversation

@ocshawn
Copy link
Contributor

@ocshawn ocshawn commented Jul 12, 2023

Improvements

  • updated error logging to use GraphQLError per documentation
  • updated schema to not need gql wrapper
  • update way ApolloServer is called

Dependency updates

  • Add "@apollo/server": "^4.7.5",
  • Remove "apollo-server": "^2.4.8",
  • Remove ""apollo-server-express": "^2.4.8",
  • "graphql": "^16.7.1",
  • "graphql-middleware": "^6.1.34",
  • "graphql-parse-resolve-info": "^4.13.0",
  • "graphql-tools": "^9.0.0",

@ocshawn
Copy link
Contributor Author

ocshawn commented Jul 19, 2023 •
edited
Loading

(no longer) loaded in QA https://qa-ibd.planx-pla.net/ and can be tested there

@ocshawn ocshawn requested a review from mfshao July 19, 2023 14:29
@mfshao
Copy link
Contributor

mfshao commented Aug 8, 2023

looks like a pretty major change and sorry I missed the testing window
when we deployed this to QA did we observe any abnormalites? I assume not since the CI has all passed 😅

@ocshawn
Copy link
Contributor Author

ocshawn commented Aug 8, 2023

everything looked good, i can load this anywhere that you want if you want to test some more

mfshao
mfshao approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@mfshao mfshao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great effort! thanks

@ocshawn ocshawn merged commit 7ee2eaa into master Aug 8, 2023
@ocshawn ocshawn deleted the chore/updateAllDep2part8 branch August 8, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfshao mfshao mfshao approved these changes

Assignees

No one assigned

Labels

@requires-guppy

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ocshawn @mfshao