this.client.search is async so this end time won't reflect when the request ends, just when it was sent.

you'll want to add a call to finally after the .then and add this and the code below.

Good catch, I'll fix it. Is it obvious I don't with Javascript very often? 😆

something like this

var searchResult = this.client.search({
  index: esIndex,
  body: validatedQueryBody,
}).then((resp) => resp.body, (err) => {
  log.error(`[ES.query] error during querying: ${err.message}`);
  throw new Error(err.message);
}).finally(() => {
   var end = new Date().getTime();
   var durationInMS = end - start;

   log.info('[ES.query] DurationInMS:' + durationInMS + '. index, type, query body: ', esIndex, esType, JSON.stringify(validatedQueryBody));
   return searchResult;
})

and no worries i almost commented on the log.info asking you to use f strings before realizing this was javascript

also if you really want to squeeze performance (and look like a JS pro), use Date.now() instead of new Date().getTime()

they're functionally the same though

Don't return from the finally - you can actually get rid of searchResult assignment and return this.client.search(...) like it was before. This function needs to return the Promise for the async call so callers of the functions can do their own async response handling.

👍 I'll push and then I'm going to test in my dev env