Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@mfshao
Copy link
Contributor

@mfshao mfshao commented Aug 27, 2024

Bug Fixes

  • Fixed a bug causing tiered access middleware didn't properly applied to aggregation results

Deployment changes

  • Important: all envs that has tiered access enabled should deploy a Guppy that has this fix

@github-actions
Copy link

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_guppy\_service.py}}$$ $$\textcolor{#23d18b}{\tt{8}}$$ $$\textcolor{#23d18b}{\tt{8}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{8}}$$ $$\textcolor{#23d18b}{\tt{8}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

Copy link

@MaribelleHGomez MaribelleHGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the dockerfile there's a warning, should we be changing ln37 to
CMD ["bash", "./startServer.sh"]

@github-actions
Copy link

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ SUBTOTAL
$$\textcolor{#23d18b}{\tt{tests/test\_guppy\_service.py}}$$ $$\textcolor{#23d18b}{\tt{8}}$$ $$\textcolor{#23d18b}{\tt{8}}$$
$$\textcolor{#23d18b}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{8}}$$ $$\textcolor{#23d18b}{\tt{8}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

Copy link

@MaribelleHGomez MaribelleHGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@mfshao mfshao merged commit a43e002 into master Aug 28, 2024
@mfshao mfshao deleted the fix/tiered-access-as-text-agg branch August 28, 2024 16:50
grugna added a commit to chicagopcdc/guppy that referenced this pull request Oct 8, 2024
matthewpeterkort pushed a commit to ACED-IDP/guppy that referenced this pull request Oct 24, 2024
* fix apply hide number resolver to as text agg results

* update dockerfile
mfshao added a commit that referenced this pull request Oct 29, 2024
* Adds initial support for guppy refresh

* Fix Formatting

* Adds create method checking, updates tests

* fix: test

* Addresses PR feedback

* chore(deps): bump braces from 3.0.2 to 3.0.3 (#271)

* chore(deps): bump braces from 3.0.2 to 3.0.3

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

* trigger gh action

* trigger travis

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mingfei Shao <[email protected]>

* chore(deps-dev): bump ws from 6.2.2 to 6.2.3 (#272)

Bumps [ws](https://github.com/websockets/ws) from 6.2.2 to 6.2.3.
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@6.2.2...6.2.3)

---
updated-dependencies:
- dependency-name: ws
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mingfei Shao <[email protected]>

* address recent feedback

* fix apply hide number resolver to as text agg results (#274)

* fix apply hide number resolver to as text agg results

* update dockerfile

* Fix param ordering in server.js (#277)

Param order was wrong on changed line, put err first.
Refer to: https://expressjs.com/en/guide/error-handling.html

* fix: package.json & package-lock.json to reduce vulnerabilities (#280)

The following vulnerabilities are fixed with an upgrade:
- https://snyk.io/vuln/SNYK-JS-SEND-7926862

Co-authored-by: snyk-bot <[email protected]>

* Update integration_tests.yaml (#284)

* (PPS-1564 PPS-1567 PPS-1585): update body-parser and package lock file to use newer dependencies (#285)

* PPS-1564 PPS-1567 PPS-1585: update body-parser and package lock file to use newer dependencies
* PPS-1564 PPS-1567 PPS-1585: add file so nvm can set node version

* Update quickstart_helm.md (#289)

Fix a dead link

* Adds initial support for guppy refresh

* run linter

* bug fixes

* fix es-lint errors

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mingfei Shao <[email protected]>
Co-authored-by: Mingfei Shao <[email protected]>
Co-authored-by: Albert Snow <[email protected]>
Co-authored-by: Binam Bajracharya <[email protected]>
Co-authored-by: snyk-bot <[email protected]>
Co-authored-by: Krishna Agarwal <[email protected]>
Co-authored-by: Shawn O'Connor <[email protected]>
Co-authored-by: smvgarcia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants