feat(unity): support customizing Arborist #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philloooo
reviewed
Jun 7, 2019
philloooo
left a comment
There was a problem hiding this comment.
we should just make the default to arborist-service.
And let people to specify mock when they are deving
Because the behavior of the existing GEN3_ARBORIST_ENDPOINT defaults to mock if not set, a new OVERRIDE is needed to avoid changing this. If the new OVERRIDE is not set, it defaults to GEN3_ARBORIST_ENDPOINT which might be just http://arborist-service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the behavior of the existing GEN3_ARBORIST_ENDPOINT defaults to mock if not set, a new OVERRIDE is needed to avoid changing this. If the new OVERRIDE is not set, it defaults to GEN3_ARBORIST_ENDPOINT which might be just http://arborist-service.As mentioned in the CR, there will be no new OVERRIDE, instead, the default value of GEN3_ARBORIST_ENDPOINT is now changed to
http://arborist-service.See also: https://github.com/uc-cdis/cloud-automation/pull/869/files#diff-ff1d8822f6c3ba09ea41626908560a26
Improvements
GEN3_ARBORIST_ENDPOINTdefaults tohttp://arborist-serviceDeployment changes