Modify the register form to assume DUA consent. #1149
Conversation
fence/templates/register_user.html
Outdated
| <form method="post"> | ||
|
|
||
| <h1 class="introduction">Register in order to get access to download data</h1> | ||
| <h1 class="introduction">Register* in order to get access to download data</h1> |
There was a problem hiding this comment.
A comment to register.
Comment in <p>.
There was a problem hiding this comment.
asterisks make sense when they refer to something else - the paragraph would need to start with an asterisk as well
but here i don't think it's necessary at all, the text is right next to the submit button and visible enough
although it might be better above the button? so you read it before you click submit
658a3c9 to
aba6f46
Compare
fence/templates/register_user.html
Outdated
| </li> | ||
| </ul> | ||
| <button class="button-primary-orange" type="submit">Register</button> | ||
| <p>By registering and submitting this form, you hereby acknowledge and consent to be bound by our terms and conditions, and our data use agreement (DUA), both of which can be found on our main website, or on our <a href="/dashboard/Public/documentation/DUA.html">data access portal</a>. </p> |
There was a problem hiding this comment.
can we link directly to the terms and conditions as well? i don't see where the link is on the portal
There was a problem hiding this comment.
Some terms and conditions are on our main website (www.midrc.org) so it's hard to find a generic url for it. It'll add MIDRC-specific contents to this page which is what I'm trying to avoid. I just checked and I think DUA itself is fine. I've modified it so it only says DUA.
* Fix REGISTERED_USERS_GROUP logic * add registration flow to fence login * fix old registration tests * fix unit tests * refactor login_user function * update doc * update registration page (#1149) * test post_registration_redirect in all idps * change audit back - flask.g.user should be there --------- Co-authored-by: Sai Shanmukha <[email protected]>
Updating the register form so its asks the user to agree to our DUA when submitting the form. Previously, the form only states that the user is submitting it.
Link to JIRA ticket if there is one:
https://ctds-planx.atlassian.net/browse/MIDRC-754
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes