Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: add a note in the migrations folder alerting about the manual migration possibility #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pieterlukasse merged 2 commits into from
Jun 9, 2025
Merged

fix: add a note in the migrations folder alerting about the manual migration possibility #1267

pieterlukasse merged 2 commits into from
Jun 9, 2025

Conversation

@pieterlukasse
Copy link
Contributor

@pieterlukasse pieterlukasse commented Jun 9, 2025 •
edited
Loading

Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/CADC-1795

Improvements

  • The assumption that all migrations are executed automatically on startup is not correct, and therefore it is crucial that the README of a PR in Fence that adds a migration, ALWAYS contains a “Deployment changes” section.
    • This PR adds a warning README in the /migrations folder to warn future developers about this.

@pieterlukasse pieterlukasse marked this pull request as ready for review June 9, 2025 18:10
@pieterlukasse pieterlukasse merged commit 74483ce into master Jun 9, 2025
10 checks passed
@pieterlukasse pieterlukasse deleted the fix/docs_on_migration branch June 9, 2025 18:15
@coveralls
Copy link

coveralls commented Jun 9, 2025

Pull Request Test Coverage Report for Build 15541369973

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.5%
Totals Coverage Status
Change from base Build 15536257925: 0.0%
Covered Lines: 8201
Relevant Lines: 11008
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulineribeyre paulineribeyre paulineribeyre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pieterlukasse @coveralls @paulineribeyre