Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix/handle error for blank guid #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
george42-ctds merged 4 commits into from
Jun 26, 2025
Merged

Fix/handle error for blank guid #1276

george42-ctds merged 4 commits into from
Jun 26, 2025

Conversation

@george42-ctds
Copy link
Contributor

@george42-ctds george42-ctds commented Jun 24, 2025 •
edited by atlassian bot
Loading

Verify that fence handles/raises errors when the create blank record has an error.

See this slack thread for context: https://cdis.slack.com/archives/C0294A7KVE0/p1749828034955709

JIRA ticket: PPS-2067

New Features

Breaking Changes

Bug Fixes

Improvements

  • Add unit tests for errors from create blank record

Dependency updates

Deployment changes

@coveralls
Copy link

coveralls commented Jun 24, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 15860000806

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.675%
Totals Coverage Status
Change from base Build 15856964263: 0.0%
Covered Lines: 8274
Relevant Lines: 11080
💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jun 24, 2025

filepath passed skipped SUBTOTAL
tests/test_oauth2.py 15 0 15
tests/test_centralized_auth.py 16 0 16
tests/test_data_upload.py 8 1 9
tests/test_presigned_url.py 7 0 7
tests/test_audit_service.py 5 0 5
tests/test_dbgap.py 4 1 5
tests/test_user_token.py 5 0 5
tests/test_drs_endpoint.py 4 0 4
tests/test_ras_authn.py 3 0 3
tests/test_oidc_client.py 2 0 2
tests/test_google_data_access.py 1 0 1
tests/test_client_credentials.py 1 0 1
tests/test_register_user.py 0 2 2
TOTAL 71 4 75

Please find the detailed integration test report here

Login here

Please find the ci env pod logs here

@github-actions
Copy link

github-actions bot commented Jun 24, 2025

filepath passed failed skipped SUBTOTAL
tests/test_oauth2.py 15 0 0 15
tests/test_centralized_auth.py 16 0 0 16
tests/test_data_upload.py 8 0 1 9
tests/test_presigned_url.py 7 0 0 7
tests/test_audit_service.py 4 1 0 5
tests/test_dbgap.py 4 0 1 5
tests/test_ras_authn.py 3 0 0 3
tests/test_drs_endpoint.py 4 0 0 4
tests/test_oidc_client.py 2 0 0 2
tests/test_google_data_access.py 1 0 0 1
tests/test_client_credentials.py 1 0 0 1
tests/test_user_token.py 5 0 0 5
tests/test_register_user.py 0 0 2 2
TOTAL 70 1 4 75

Please find the detailed integration test report here

Login here

Please find the ci env pod logs here

@github-actions
Copy link

github-actions bot commented Jun 25, 2025

filepath passed skipped SUBTOTAL
tests/test_oauth2.py 15 0 15
tests/test_centralized_auth.py 16 0 16
tests/test_audit_service.py 6 0 6
tests/test_ras_authn.py 3 0 3
tests/test_data_upload.py 8 1 9
tests/test_presigned_url.py 7 0 7
tests/test_dbgap.py 4 1 5
tests/test_user_token.py 5 0 5
tests/test_drs_endpoint.py 4 0 4
tests/test_client_credentials.py 1 0 1
tests/test_oidc_client.py 2 0 2
tests/test_google_data_access.py 1 0 1
tests/test_register_user.py 0 2 2
TOTAL 72 4 76

Please find the detailed integration test report here

Login here

Please find the ci env pod logs here

@george42-ctds george42-ctds merged commit f58b909 into master Jun 26, 2025
11 of 12 checks passed
@george42-ctds george42-ctds deleted the fix/handle-error-for-blank-guid branch June 26, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulineribeyre paulineribeyre paulineribeyre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@george42-ctds @coveralls @paulineribeyre