Chore/add hide idps #1304

george42-ctds · 2025-10-13T22:01:18Z

JIRA ticket: HP-2270

New Features

Allow a HIDE_IDPS configuration option when shib_ipds=*

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

coveralls · 2025-10-13T22:42:04Z

Pull Request Test Coverage Report for Build 19143615376

Details

0 of 0 changed or added relevant lines in 0 files are covered.
39 unchanged lines in 3 files lost coverage.
Overall coverage increased (+0.009%) to 74.969%

Files with Coverage Reduction	New Missed Lines	%
resources/ga4gh/passports.py	2	87.43%
config.py	16	67.14%
blueprints/login/init.py	21	87.04%

Totals
Change from base Build 19048361372:	0.009%
Covered Lines:	8437
Relevant Lines:	11254

💛 - Coveralls

github-actions · 2025-10-13T22:46:30Z

filepath	passed	skipped	SUBTOTAL
tests/test_oauth2.py	15	0	15
tests/test_centralized_auth.py	16	0	16
tests/test_audit_service.py	3	3	6
tests/test_data_upload.py	8	1	9
tests/test_presigned_url.py	7	0	7
tests/test_dbgap.py	4	1	5
tests/test_drs_endpoint.py	4	0	4
tests/test_oidc_client.py	2	0	2
tests/test_user_token.py	5	0	5
tests/test_google_data_access.py	1	0	1
tests/test_client_credentials.py	1	0	1
tests/test_ras_authn.py	0	3	3
tests/test_register_user.py	0	2	2
TOTAL	66	10	76

Please find the detailed integration test report here

Please find the Github Action logs here

mfshao · 2025-10-21T15:19:07Z

fence/blueprints/login/__init__.py

        upstream_idps = UPSTREAM_IDP_CACHE.get(cache_key)
+        if hide_idps_list and len(hide_idps_list) > 0:
+            hidden_idps_excluded = [
+                x for x in upstream_idps if x.get("name") not in hide_idps_list


I think the idea is right. But I also think we should be putting the IDP's entityID into HIDE_IDPS instead of their names. Since this is how Shibboleth IDPs can be configured to enable in Fence config now, like

fence/docs/additional_documentation/fence_shibboleth.md

Lines 84 to 86 in 2a0ede3

shib_idps:

- urn:mace:incommon:nih.gov

- urn:mace:incommon:uchicago.edu

The hide list is updated to use idp instead of name. The unit test cases have been expanded to show that this works when shib_idsp=[list] in addition to shib_idps=*.

github-actions · 2025-10-22T18:23:10Z

filepath	passed	skipped	SUBTOTAL
tests/test_oauth2.py	15	0	15
tests/test_centralized_auth.py	16	0	16
tests/test_audit_service.py	3	3	6
tests/test_data_upload.py	8	1	9
tests/test_presigned_url.py	7	0	7
tests/test_dbgap.py	4	1	5
tests/test_drs_endpoint.py	4	0	4
tests/test_oidc_client.py	2	0	2
tests/test_user_token.py	5	0	5
tests/test_google_data_access.py	1	0	1
tests/test_client_credentials.py	1	0	1
tests/test_ras_authn.py	0	3	3
tests/test_register_user.py	0	2	2
TOTAL	66	10	76

Please find the detailed integration test report here

Please find the Github Action logs here

github-actions · 2025-10-22T19:13:51Z

filepath	passed	error	skipped	SUBTOTAL
tests/test_oauth2.py	15	0	0	15
tests/test_centralized_auth.py	16	0	0	16
tests/test_audit_service.py	3	0	3	6
tests/test_data_upload.py	7	3	1	11
tests/test_presigned_url.py	7	0	0	7
tests/test_dbgap.py	4	0	1	5
tests/test_drs_endpoint.py	4	0	0	4
tests/test_oidc_client.py	2	0	0	2
tests/test_user_token.py	5	0	0	5
tests/test_google_data_access.py	1	0	0	1
tests/test_client_credentials.py	1	0	0	1
tests/test_ras_authn.py	0	0	3	3
tests/test_register_user.py	0	0	2	2
TOTAL	65	3	10	78

Please find the detailed integration test report here

Please find the Github Action logs here

github-actions · 2025-10-22T19:59:15Z

filepath	passed	failed	skipped	SUBTOTAL
tests/test_oauth2.py	15	0	0	15
tests/test_centralized_auth.py	16	0	0	16
tests/test_audit_service.py	3	0	3	6
tests/test_data_upload.py	7	1	1	9
tests/test_presigned_url.py	7	0	0	7
tests/test_dbgap.py	4	0	1	5
tests/test_drs_endpoint.py	4	0	0	4
tests/test_oidc_client.py	2	0	0	2
tests/test_user_token.py	5	0	0	5
tests/test_google_data_access.py	1	0	0	1
tests/test_client_credentials.py	1	0	0	1
tests/test_ras_authn.py	0	0	3	3
tests/test_register_user.py	0	0	2	2
TOTAL	65	1	10	76

Please find the detailed integration test report here

Please find the Github Action logs here

github-actions · 2025-10-22T21:48:55Z

filepath	passed	failed	skipped	SUBTOTAL
tests/test_oauth2.py	15	0	0	15
tests/test_centralized_auth.py	16	0	0	16
tests/test_audit_service.py	3	0	3	6
tests/test_data_upload.py	8	0	1	9
tests/test_presigned_url.py	7	0	0	7
tests/test_dbgap.py	4	0	1	5
tests/test_drs_endpoint.py	4	0	0	4
tests/test_oidc_client.py	2	0	0	2
tests/test_client_credentials.py	1	0	0	1
tests/test_user_token.py	5	0	0	5
tests/test_ras_authn.py	0	0	3	3
tests/test_register_user.py	0	0	2	2
tests/test_google_data_access.py	0	1	0	1
TOTAL	65	1	10	76

Please find the detailed integration test report here

Please find the Github Action logs here

github-actions · 2025-10-22T22:25:09Z

filepath	SUBTOTAL
TOTAL	0

Please find the detailed integration test report here

Please find the Github Action logs here

github-actions · 2025-10-23T14:28:29Z

filepath	passed	error	SUBTOTAL
tests/test_discoverypage.py	0	5	5
tests/test_google_data_access.py	1	0	1
TOTAL	1	5	6

Please find the detailed integration test report here

Please find the Github Action logs here

github-actions · 2025-10-23T15:39:56Z

filepath	passed	SUBTOTAL
tests/test_google_data_access.py	1	1
TOTAL	1	1

Please find the detailed integration test report here

Please find the Github Action logs here

mfshao · 2025-10-23T15:58:04Z

fence/config-default.yaml

 ITRUST_GLOBAL_LOGOUT: 'https://auth.nih.gov/siteminderagent/smlogout.asp?mode=nih&AppReturnUrl='

+# The following names will be hidden from the InCommons drop down list when shib_idps=*
+# eg, HIDE_IDPS = ["The University of Texas Southwestern Medical Center"]


I think we should update this example (and the other one below as well)

This example HIDE_IDPS has been updated. Is there another one that needs updating?

github-actions · 2025-10-23T17:15:42Z

filepath	passed	skipped	SUBTOTAL
tests/test_oauth2.py	15	0	15
tests/test_centralized_auth.py	16	0	16
tests/test_audit_service.py	3	3	6
tests/test_data_upload.py	8	1	9
tests/test_presigned_url.py	7	0	7
tests/test_dbgap.py	4	1	5
tests/test_drs_endpoint.py	4	0	4
tests/test_oidc_client.py	2	0	2
tests/test_user_token.py	5	0	5
tests/test_google_data_access.py	1	0	1
tests/test_client_credentials.py	1	0	1
tests/test_ras_authn.py	0	3	3
tests/test_register_user.py	0	2	2
TOTAL	66	10	76

Please find the detailed integration test report here

Please find the Github Action logs here

mfshao

looks good!

github-actions · 2025-11-06T17:25:35Z

Failed to Prepare CI environment

Please find the Github Action logs here

github-actions · 2025-11-06T19:09:11Z

filepath	passed	skipped	SUBTOTAL
tests/test_oauth2.py	15	0	15
tests/test_centralized_auth.py	16	0	16
tests/test_audit_service.py	3	3	6
tests/test_data_upload.py	8	1	9
tests/test_presigned_url.py	7	0	7
tests/test_dbgap.py	4	1	5
tests/test_drs_endpoint.py	4	0	4
tests/test_oidc_client.py	2	0	2
tests/test_user_token.py	5	0	5
tests/test_google_data_access.py	1	0	1
tests/test_client_credentials.py	1	0	1
tests/test_ras_authn.py	0	3	3
tests/test_register_user.py	0	2	2
TOTAL	66	10	76

Please find the detailed integration test report here

Please find the Github Action logs here

george42-ctds added 6 commits October 9, 2025 08:13

(HP-2270) Add hardwired hide_idps list

9016f3e

Dummy commit

4edf177

(HP-2270) use name value from upstream_idps

e1f052f

(HP-2270) move HIDE_IDPS list to config

b04cd02

(HP-2270) update name of list

ef7dc5c

(HP-2270) add test for hide_idps

985fe7e

mfshao reviewed Oct 21, 2025

View reviewed changes

(HP-2270) Change hide logic from 'name' to 'idp'

5dbe1af

Merge branch 'master' into chore/add-hide-idps

5f13d4e

Merge branch 'master' into chore/add-hide-idps

d5b5b62

george42-ctds added the TestGoogleDataAccess label Oct 22, 2025

mfshao reviewed Oct 23, 2025

View reviewed changes

george42-ctds removed the TestGoogleDataAccess label Oct 23, 2025

(HP-2270) Update comments in 'config-default.yaml'

6662596

mfshao approved these changes Nov 6, 2025

View reviewed changes

Merge branch 'master' into chore/add-hide-idps

5685aa3

george42-ctds merged commit 4173550 into master Nov 6, 2025
11 of 12 checks passed

george42-ctds deleted the chore/add-hide-idps branch November 6, 2025 19:09

	shib_idps:
	- urn:mace:incommon:nih.gov
	- urn:mace:incommon:uchicago.edu

Chore/add hide idps #1304

Chore/add hide idps #1304

Uh oh!

Conversation

george42-ctds commented Oct 13, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Features

Breaking Changes

Bug Fixes

Improvements

Dependency updates

Deployment changes

Uh oh!

coveralls commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 19143615376

Details

💛 - Coveralls

Uh oh!

github-actions bot commented Oct 13, 2025

Uh oh!

mfshao Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

george42-ctds Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 22, 2025

Uh oh!

github-actions bot commented Oct 22, 2025

Uh oh!

github-actions bot commented Oct 22, 2025

Uh oh!

github-actions bot commented Oct 22, 2025

Uh oh!

github-actions bot commented Oct 22, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

mfshao Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

george42-ctds Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

mfshao left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

george42-ctds commented Oct 13, 2025 •

edited by atlassian bot

Loading

coveralls commented Oct 13, 2025 •

edited

Loading