Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@AlbertSnows
Copy link
Contributor

@AlbertSnows AlbertSnows commented Mar 26, 2024

also adding a small note to have postgres installed.

Link to JIRA ticket if there is one: n/a

New Features - n/a

Breaking Changes - n/a

Bug Fixes - n/a

Improvements

  • add a bit more clarity regarding setup prereqs

Dependency updates - n/a

Deployment changes - n/a

also adding a small note to have postgres installed.
@github-actions
Copy link

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@AlbertSnows AlbertSnows marked this pull request as ready for review March 26, 2024 16:15
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8439293334

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.438%

Totals Coverage Status
Change from base Build 8178427239: 0.0%
Covered Lines: 5139
Relevant Lines: 7509

💛 - Coveralls

@Avantol13
Copy link
Contributor

Don't add anything in the PR description for headings where there are no updates. e.g. don't put n/a b/c that will get grabbed in release notes. Also make sure the item you do add is a bullet under the heading (not in the heading itself)

@Avantol13
Copy link
Contributor

Thanks for updating the docs and making the requirements more clear ❤️

@k-burt-uch
Copy link
Contributor

Thanks for updating this.

Just a heads up - our PR descriptions get automated into release notes that are externally facing. As such, there's a specific format that requires changes to be list items under the headers.

https://github.com/uc-cdis/datastage-users/pull/1265

for example.

I went ahead and fixed it here.

@k-burt-uch k-burt-uch merged commit d200ae8 into master Mar 26, 2024
@k-burt-uch k-burt-uch deleted the add-postgres-prereq branch March 26, 2024 17:55
@AlbertSnows
Copy link
Contributor Author

noted, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants