Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: get_delimited_template handles streams as bytes #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
k-burt-uch merged 3 commits into from
Mar 12, 2025
Merged

fix: get_delimited_template handles streams as bytes #429

k-burt-uch merged 3 commits into from
Mar 12, 2025

Conversation

@k-burt-uch
Copy link
Contributor

@k-burt-uch k-burt-uch commented Feb 11, 2025

Link to JIRA ticket if there is one:

New Features

Breaking Changes

Bug Fixes

  • Fixes the /template endpoint to not error when using json file format

Improvements

Dependency updates

Deployment changes

@github-actions
Copy link

github-actions bot commented Feb 11, 2025

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@github-actions
Copy link

github-actions bot commented Feb 11, 2025

Please find the ci env pod logs here

@github-actions
Copy link

github-actions bot commented Feb 11, 2025

Please find the ci env pod logs here

@github-actions
Copy link

github-actions bot commented Feb 13, 2025

Please find the ci env pod logs here

@coveralls
Copy link

coveralls commented Feb 13, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13788682838

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 62.431%
Totals Coverage Status
Change from base Build 13457636479: 0.5%
Covered Lines: 2373
Relevant Lines: 3801
💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Feb 17, 2025

Please find the ci env pod logs here

@github-actions
Copy link

github-actions bot commented Feb 19, 2025

Please find the ci env pod logs here

@github-actions
Copy link

github-actions bot commented Feb 19, 2025

Please find the ci env pod logs here

@github-actions
Copy link

github-actions bot commented Feb 21, 2025

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ $$\textcolor{#f14c4c}{\tt{failed}}$$ $$\textcolor{#ffa500}{\tt{skipped}}$$ SUBTOTAL
$$\textcolor{#f14c4c}{\tt{tests/test\_graph\_submit\_and\_query.py}}$$ $$\textcolor{#23d18b}{\tt{12}}$$ $$\textcolor{#f14c4c}{\tt{1}}$$ $$\textcolor{#ffa500}{\tt{1}}$$ $$\textcolor{#f14c4c}{\tt{14}}$$
$$\textcolor{#f14c4c}{\tt{tests/test\_data\_upload.py}}$$ $$\textcolor{#23d18b}{\tt{6}}$$ $$\textcolor{#f14c4c}{\tt{2}}$$ $$\textcolor{#ffa500}{\tt{1}}$$ $$\textcolor{#f14c4c}{\tt{9}}$$
$$\textcolor{#f14c4c}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{18}}$$ $$\textcolor{#f14c4c}{\tt{3}}$$ $$\textcolor{#ffa500}{\tt{2}}$$ $$\textcolor{#f14c4c}{\tt{23}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

@github-actions
Copy link

github-actions bot commented Mar 11, 2025

Please find the ci env pod logs here

@github-actions
Copy link

github-actions bot commented Mar 11, 2025

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ $$\textcolor{#ffa500}{\tt{skipped}}$$ SUBTOTAL
$$\textcolor{#ffa500}{\tt{tests/test\_graph\_submit\_and\_query.py}}$$ $$\textcolor{#23d18b}{\tt{13}}$$ $$\textcolor{#ffa500}{\tt{1}}$$ $$\textcolor{#ffa500}{\tt{14}}$$
$$\textcolor{#ffa500}{\tt{tests/test\_data\_upload.py}}$$ $$\textcolor{#23d18b}{\tt{8}}$$ $$\textcolor{#ffa500}{\tt{1}}$$ $$\textcolor{#ffa500}{\tt{9}}$$
$$\textcolor{#ffa500}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{21}}$$ $$\textcolor{#ffa500}{\tt{2}}$$ $$\textcolor{#ffa500}{\tt{23}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

nss10
nss10 approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@nss10 nss10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@k-burt-uch k-burt-uch merged commit f3f290e into master Mar 12, 2025
8 checks passed
@k-burt-uch k-burt-uch deleted the fix/template branch March 12, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nss10 nss10 nss10 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@k-burt-uch @coveralls @nss10