Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Chore/remove gdc from docstrings #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
george42-ctds merged 4 commits into from
Mar 28, 2025
Merged

Chore/remove gdc from docstrings #434

george42-ctds merged 4 commits into from
Mar 28, 2025

Conversation

@george42-ctds
Copy link
Contributor

@george42-ctds george42-ctds commented Mar 24, 2025

This slack thread show some motivation for updating the sheepdog api documentation:
https://cdis.slack.com/archives/C0294A7KVE0/p1742827500241829

New Features

Breaking Changes

Bug Fixes

Improvements

  • Remove references to GDC in docstrings and comments.

Dependency updates

Deployment changes

@github-actions
Copy link

github-actions bot commented Mar 24, 2025

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@coveralls
Copy link

coveralls commented Mar 24, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 14073867582

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 46 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 62.431%
Files with Coverage Reduction New Missed Lines %
blueprint/routes/views/program/project.py 46 61.59%
Totals Coverage Status
Change from base Build 14000946386: 0.0%
Covered Lines: 2373
Relevant Lines: 3801
💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Mar 25, 2025

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ $$\textcolor{#f14c4c}{\tt{failed}}$$ $$\textcolor{#ffa500}{\tt{skipped}}$$ SUBTOTAL
$$\textcolor{#f14c4c}{\tt{tests/test\_graph\_submit\_and\_query.py}}$$ $$\textcolor{#23d18b}{\tt{12}}$$ $$\textcolor{#f14c4c}{\tt{1}}$$ $$\textcolor{#ffa500}{\tt{1}}$$ $$\textcolor{#f14c4c}{\tt{14}}$$
$$\textcolor{#f14c4c}{\tt{tests/test\_data\_upload.py}}$$ $$\textcolor{#23d18b}{\tt{7}}$$ $$\textcolor{#f14c4c}{\tt{1}}$$ $$\textcolor{#ffa500}{\tt{1}}$$ $$\textcolor{#f14c4c}{\tt{9}}$$
$$\textcolor{#f14c4c}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{19}}$$ $$\textcolor{#f14c4c}{\tt{2}}$$ $$\textcolor{#ffa500}{\tt{2}}$$ $$\textcolor{#f14c4c}{\tt{23}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

paulineribeyre
paulineribeyre previously approved these changes Mar 25, 2025
View reviewed changes
sheepdog/blueprint/routes/views/program/project.py Outdated
Comment on lines 757 to 759
Submitting a project means that the Gen3 commons can make all metadata that
*currently* exists in the project public in every index built after
the project is released.
Copy link
Contributor

@paulineribeyre paulineribeyre Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what this is about. Let's remove this paragraph

Copy link
Contributor Author

@george42-ctds george42-ctds Mar 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me!

@github-actions
Copy link

github-actions bot commented Mar 26, 2025

Please find the ci env pod logs here

paulineribeyre
paulineribeyre approved these changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@paulineribeyre paulineribeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@github-actions
Copy link

github-actions bot commented Mar 27, 2025

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ $$\textcolor{#f14c4c}{\tt{failed}}$$ $$\textcolor{#ffa500}{\tt{skipped}}$$ SUBTOTAL
$$\textcolor{#ffa500}{\tt{tests/test\_graph\_submit\_and\_query.py}}$$ $$\textcolor{#23d18b}{\tt{13}}$$ $$\textcolor{#666666}{\tt{0}}$$ $$\textcolor{#ffa500}{\tt{1}}$$ $$\textcolor{#ffa500}{\tt{14}}$$
$$\textcolor{#f14c4c}{\tt{tests/test\_data\_upload.py}}$$ $$\textcolor{#23d18b}{\tt{7}}$$ $$\textcolor{#f14c4c}{\tt{1}}$$ $$\textcolor{#ffa500}{\tt{1}}$$ $$\textcolor{#f14c4c}{\tt{9}}$$
$$\textcolor{#f14c4c}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{20}}$$ $$\textcolor{#f14c4c}{\tt{1}}$$ $$\textcolor{#ffa500}{\tt{2}}$$ $$\textcolor{#f14c4c}{\tt{23}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

@github-actions
Copy link

github-actions bot commented Mar 28, 2025

filepath $$\textcolor{#23d18b}{\tt{passed}}$$ $$\textcolor{#ffa500}{\tt{skipped}}$$ SUBTOTAL
$$\textcolor{#ffa500}{\tt{tests/test\_graph\_submit\_and\_query.py}}$$ $$\textcolor{#23d18b}{\tt{13}}$$ $$\textcolor{#ffa500}{\tt{1}}$$ $$\textcolor{#ffa500}{\tt{14}}$$
$$\textcolor{#ffa500}{\tt{tests/test\_data\_upload.py}}$$ $$\textcolor{#23d18b}{\tt{8}}$$ $$\textcolor{#ffa500}{\tt{1}}$$ $$\textcolor{#ffa500}{\tt{9}}$$
$$\textcolor{#ffa500}{\tt{TOTAL}}$$ $$\textcolor{#23d18b}{\tt{21}}$$ $$\textcolor{#ffa500}{\tt{2}}$$ $$\textcolor{#ffa500}{\tt{23}}$$

Please find the detailed integration test report here

Please find the ci env pod logs here

@george42-ctds george42-ctds merged commit a536d33 into master Mar 28, 2025
8 checks passed
@george42-ctds george42-ctds deleted the chore/remove-gdc-from-docstrings branch March 28, 2025 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulineribeyre paulineribeyre paulineribeyre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@george42-ctds @coveralls @paulineribeyre