PXP-9266 Split SSL and isolation level tests #364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
johnfrancismccann
previously approved these changes
Jan 25, 2022
Contributor
johnfrancismccann
left a comment
There was a problem hiding this comment.
This is awesome! My only suggestion would be to use shared helper functions to reduce code duplication of the functional tests if possible (e.g. a helper for the four definitions of test_post_example_entities_together).
Contributor
Author
|
@johnfrancismccann we could do that, but most sheepdog tests are duplicated in |
d7e326e to
84aeb7d
Compare
paulineribeyre
commented
Jan 26, 2022
|
|
||
|
|
||
| def test_post_example_entities_together(client, pg_driver, cgci_blgsp, submitter): | ||
| def do_test_post_example_entities_together(client, submitter): |
Contributor
Author
There was a problem hiding this comment.
not importing it from datadict because the datadictwithobjid test data might be different
johnfrancismccann
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Ticket: PXP-9266
Improvements
pg_driverfixture were ran 12 times