-
Notifications
You must be signed in to change notification settings - Fork 221
added cisc frontend #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ssteffl
commented
Aug 25, 2020
- gemmini cisc frontend and risc frontend co-exist
- there is currently no way to remove either frontend
- there are no special instructions to switch between the modes. the risc/cisc mode is inferred from the RoCC funct7 field
- there are mechanisms in the Chisel to prevent the risc/cisc from issuing/commiting instructions at the same time
- verified risc/cisc both work and can switch between on verilator using several gemm-rocc-tests bareMetalC tests
|
Thanks for opening this PR!
|
its a submodule that sits parallel to the existing LoopUnroller+ROB frontend. it could be renamed "TilerFrontend"
transposing input matrices is not supported by the hardware tiler. that sounds like it would be a bit of work.
sure you could add that, but i'm guessing the saved area will be fairly small
i dont care about the external branding of this addition. HWTiler is fine with me. the code has "cisc" 32 times, but can easily be sed'ed with "tiler" if desired |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ssteffl! This looks pretty good overall. I just left a few comments here. If you can respond to them, I think we can merge this by Friday night.
|
The code LGTM. There's actually one last thing that I forgot to ask about before: Could you add a section to the README.md describing the format of the CISC instructions (somewhere underneath the ISA section perhaps)? |
|
Was this tested on FireSim with the various ResNet/MobileNet tests? |
the original, unmerged Tiler code was tested on FireSim for ResNet/MobileNet. However, FireSim was not run on the merged code in this PR. |
done |
|
We apparently pass on FireSim, so this looks good to merge. |