sky130: fix I/O modifications #878
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sky130 tech JSON references the modified I/O LEFs, so the plugin as-is currently breaks with a missing file. This commit un-comments the modifications and fixes it. As of the following PDK commits, the begin/end lines are now correct and this hack is no longer needed. skywater-pdk 7198cf647113f56041e02abf3eb623692820c5e1 open_pdks 320597ea84b2816eb2fcc4fbe10c3874f19c92fc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sky130 tech JSON references the modified I/O LEFs, so the plugin as-is currently breaks with a missing file.
This commit un-comments the modifications and fixes it. As of the following PDK commits, the begin/end lines are now correct and this hack is no longer needed.
skywater-pdk 7198cf647113f56041e02abf3eb623692820c5e1
open_pdks 320597ea84b2816eb2fcc4fbe10c3874f19c92fc
Related PRs / Issues
Type of change:
Impact:
Contributor Checklist:
masteras the base branch?