Jcs/duplicate user check #1373
Merged
Jcs/duplicate user check #1373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to implement a duplicate user check when adding a person to a team and enhance the API code regeneration view by displaying additional team information.
- Forces a lookup of the user from the identity service.
- Adds a duplicate user check in PeopleController with an appropriate error message.
- Updates the RegenerateApiCode view to display the team slug and id alongside the current API code.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Keas.Mvc/Views/TeamAdmin/RegenerateApiCode.cshtml | Updated view to display team slug and id with the API code. |
| Keas.Mvc/Controllers/Api/PeopleController.cs | Modified user lookup and added a duplicate user check to prevent adding the same user twice on a team. |
Comments suppressed due to low confidence (1)
Keas.Mvc/Controllers/Api/PeopleController.cs:254
- The variable 'user' is used without an explicit declaration. If 'user' is not declared in an outer scope, consider declaring it (e.g., using 'var user = ...') to ensure proper variable scope.
user = await _identityService.GetByKerberos(person.UserId);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.