-
Notifications
You must be signed in to change notification settings - Fork 3
Jcs/recharge auto approve job #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Introduces a new feature that allows for automatic approval of recharge requests after a specified number of days. The number of days before auto-approval is configurable via settings, defaulting to 7 days. This is displayed in the financial approval email, informing approvers of the pending auto-approval.
Implements a new job that automatically approves recharge invoices meeting certain criteria (type, status, paid date). The job checks for invoices of type "Recharge" with "PendingApproval" status that have been paid for a specified number of days. If these conditions are met, the job automatically approves the invoice and the associated debit recharge accounts. Adds necessary configuration settings and database context setup.
Adds tasks to the pipeline to build and publish the auto-approve job. Also adds .NET 8 SDK usage to the pipeline build steps. Relates to JCS/RechargeAutoApproveJob
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Removes the AggieEnterprise configuration settings from the appsettings.json file. These settings are no longer needed for the RechargeAutoApproveJob.
srkirkland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
db save comment and also loading the .net 8 sdk right after the .net 6 sdk in the pipeline is just going to cause headaches later, standardize on one.
Downgrades the AutoApprove job from .NET 8 to .NET 6 due to build agent compatibility issues. Removes .NET 8 SDK usage from the pipeline and updates the project target framework. Changes the Main method to synchronous and updates async calls to synchronous calls.
Updates the Stackify app name in the configuration file to reflect the correct job name. This ensures that logging and monitoring are correctly associated with the auto-approve job.
Updates the project path for the AutoApprove job in the Azure Pipelines configuration to ensure the job is correctly located and published.
Removes the database save operation from the finally block in the AutoApprove job. This change streamlines the job's execution flow by removing a redundant database save operation which improves performance. Relates to JCS/RechargeAutoApproveJob
Updates the recharge invoice approval process by fixing a typo in auto-approval job, preventing access to draft/cancelled/sent invoices during approval, and ensuring the correct status is checked on the details page. This change enhances the user experience and ensures data integrity during the invoice approval workflow.
Improves recharge invoice approval flow
Automatically approves recharge invoices when the customer email matches the user email and the invoice has debit recharge accounts. This speeds up the approval process for self-recharge scenarios.
Streamlines recharge invoice approval
Adds a history record for when a recharge invoice is sent to financial approvers. This allows tracking of when and to whom approval requests were sent. Updates the invoice service to return the approval model.
In sloth This change is made to ensure that recharge transactions are properly validated from the start, improving data integrity and reducing the risk of errors.
No description provided.