Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Improves chart string validation display #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jSylvestre merged 1 commit into from
Nov 19, 2025
Merged

Improves chart string validation display #467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 25 additions & 18 deletions src/Payments.Mvc/Views/Invoices/Details.cshtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1176,31 +1176,33 @@ else
}
});

let resultHtml = '';
// Clear existing content
statusSpan.textContent = '';

if (validationResult.isValid) {
resultHtml = '<i class="fas fa-check-circle text-success" title="Valid chart string"></i>';
const checkIcon = document.createElement('i');
checkIcon.className = 'fas fa-check-circle text-success';
checkIcon.setAttribute('title', 'Valid chart string');
statusSpan.appendChild(checkIcon);

// Add warnings if they exist
if (validationResult.warnings && validationResult.warnings.length > 0) {
const sanitizedWarnings = validationResult.warnings.map(w => {
const key = document.createTextNode(w.key).textContent;
const value = document.createTextNode(w.value).textContent;
return key + ': ' + value;
}).join('; ');
const warningTitle = document.createElement('div');
warningTitle.textContent = sanitizedWarnings;
resultHtml += ' <i class="fas fa-exclamation-triangle text-warning ms-1" title="' +
warningTitle.textContent + '"></i>';
const warningMessages = validationResult.warnings.map(w =>
`${w.key}: ${w.value}`
).join('; ');

const warningIcon = document.createElement('i');
warningIcon.className = 'fas fa-exclamation-triangle text-warning ms-1';
warningIcon.setAttribute('title', warningMessages);
statusSpan.appendChild(warningIcon);
}
} else {
const errorDiv = document.createElement('div');
errorDiv.textContent = validationResult.messages ? validationResult.messages.join('; ') : 'Invalid chart string';
const errorMessages = errorDiv.textContent;
resultHtml = '<i class="fas fa-times-circle text-danger" title="' + errorMessages + '"></i>';
const errorMessages = validationResult.messages ? validationResult.messages.join('; ') : 'Invalid chart string';
const errorIcon = document.createElement('i');
errorIcon.className = 'fas fa-times-circle text-danger';
errorIcon.setAttribute('title', errorMessages);
statusSpan.appendChild(errorIcon);
}

statusSpan.innerHTML = resultHtml;

// Initialize tooltips for the newly added elements
$(statusSpan).find('[title]').each(function() {
Expand All @@ -1220,7 +1222,12 @@ else
}
});

statusSpan.innerHTML = '<i class="fas fa-exclamation-triangle text-warning" title="' + errorMessage + '"></i>';
// Clear existing content and create warning icon safely
statusSpan.textContent = '';
const warningIcon = document.createElement('i');
warningIcon.className = 'fas fa-exclamation-triangle text-warning';
warningIcon.setAttribute('title', errorMessage);
statusSpan.appendChild(warningIcon);

// Initialize tooltips for the newly added elements
$(statusSpan).find('[title]').each(function() {
Expand Down
Loading