Honor redirect status codes 307 and 308 in udc #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
URLs from ENCODE can generate 307 redirect codes, which udc ignores. Adding support for 307 and 308 codes (https://stackoverflow.com/a/42138726) to fix to make such URLs work.
|
Dear Nezar, |
|
Thanks! |
nvictus
added a commit
to nvictus/pybbi
that referenced
this pull request
Dec 8, 2019
My original PR: ucscGenomeBrowser/kent#23 Their changes: ucscGenomeBrowser/kent@7807b5c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLs from ENCODE, such as such as https://www.encodeproject.org/files/ENCFF620UMO/@@download/ENCFF620UMO.bigWig can initially generate 307 redirect codes, which udc ignores, and therefore the read fails.
This PR makes udc recognize 307 and 308 codes in addition to 301 and 302.