Fixed routing issue when route_prefix not in request_path #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yordis
requested changes
Aug 14, 2020
lib/ueberauth.ex
Outdated
Comment on lines
249
to
253
| route_key = | ||
| case route_path do | ||
| "/" <> _rest -> {route_path, conn.method} | ||
| route_path -> {"/" <> route_path, conn.method} | ||
| end |
There was a problem hiding this comment.
Would you mind creating a function called normalize_route_path where you return the route_path normalized
Suggested change
| route_key = | |
| case route_path do | |
| "/" <> _rest -> {route_path, conn.method} | |
| route_path -> {"/" <> route_path, conn.method} | |
| end | |
| route_key = {normaliz_route_path(route_path), conn.method} |
8fb6fe3 to
77991d2
Compare
yordis
approved these changes
Aug 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles an issue when the route_prefix is not found in the request_path.
e.g. when
Then the route key incorrectly becomes
//auth/github.This patch fixes it to ensure that it stays as
/auth/githubFor context, this situation arose from me setting my endpoint url.path to "/audit_logs", but using an ingress controller to rewrite the "/audit_logs" prefix out of all requests once it's forwarded to the application. This is due to phoenix sockets not using the endpoint path.