Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

chulkilee
Copy link
Contributor

From #129 (CC @Hanspagh)

I figured out that plug 1.10.1 is the first version breaking tests with Plug.Conn.Unfetched.

mix deps.get && mix test test/ueberauth_test.exs:181

The diff is elixir-plug/plug@v1.10.0...v1.10.1 and now Plug.Test.conn/3 correctly populates params, not body_params for params given for a get request.

Thus... change the test function to use params, not body_params.

Unchanged:

- bunt 0.2.0
- metrics 1.0.1

Upgraded:

- certifi 2.3.1 => 2.5.3
- credo 0.9.2 => 1.5.5 (major)
- dialyxir 0.5.1 => 1.1.0 (major)
- ex_doc 0.19.3 => 0.23.0 (minor)
- excoveralls 0.8.2 => 0.14.0 (minor)
- hackney 1.12.1 => 1.17.0
- idna 5.1.1 => 6.1.1 (major)
- inch_ex 0.5.6 => 2.0.0 (major)
- makeup 0.8.0 => 1.0.5 (major)
- makeup_elixir 0.13.0 => 0.15.1 (minor)
- mime 1.2.0 => 1.5.0
- mimerl 1.0.2 => 1.2.0
- nimble_parsec 0.5.0 => 1.1.0 (major)
- parse_trans 3.2.0 => 3.3.1
- plug 1.5.0 => 1.11.0
- ssl_verify_fun 1.1.1 => 1.1.6
- unicode_util_compat 0.3.1 => 0.7.0 (minor)

New:

- earmark_parser 1.4.12
- erlex 0.2.6
- file_system 0.2.10
- jason 1.2.2
- plug_crypto 1.2.1
- telemetry 0.4.2

Removed:

- earmark
- exjsx
- jsx
- poison
Plug.Test.conn/3 takes params_or_body and the recent version of plug
correctly populates params, not body_params, for GET requests.
@chulkilee chulkilee requested a review from a team as a code owner March 4, 2021 14:31
@chulkilee chulkilee mentioned this pull request Mar 4, 2021
@yordis yordis merged commit 9b9b0da into ueberauth:master Mar 7, 2021
@chulkilee chulkilee deleted the update-devtest-deps branch March 7, 2021 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants